#3330. Add static extensions tests. Part 2. #3382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Nov 5, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, couple of comments!
sgrekhov
commented
Nov 5, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Updated. Typos are fixed. One question about additional extentions. PTAL.
eernstg
reviewed
Nov 7, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Just one comment thread still being resolved.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 14, 2025
2025-11-13 sgrekhov22@gmail.com dart-lang/co19#3315. Move other `grammar_*` to `Primary-constructors` (dart-lang/co19#3391) 2025-11-13 sgrekhov22@gmail.com dart-lang/co19#3315. Move/add name conflict tests to `Primary-constructors`. (dart-lang/co19#3393) 2025-11-12 sgrekhov22@gmail.com dart-lang/co19#3315. Add grammar tests for `factory()` (dart-lang/co19#3390) 2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3315. Move `grammar_A01_t*` to `Primary-constructors` (dart-lang/co19#3389) 2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add test for the lexical lookup (dart-lang/co19#3387) 2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add static extensions tests. Part 2. (dart-lang/co19#3382) 2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add debugger tests for static extensions (dart-lang/co19#3383) 2025-11-10 sgrekhov22@gmail.com dart-lang/co19#2825. Fix async functions call in scope_A06_t02.dart (dart-lang/co19#3386) 2025-11-07 biggs0125@gmail.com Use correct async helpers and awaits in LanguageFeatures/Parts-with-imports/scope_A06_t03.dart (dart-lang/co19#3384) R=athom@google.com, eernst@google.com Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I308e558680dded4d76eb701a8033ae2dbd758505 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461821 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.